Re: [COMMITTERS] pgsql: Arrange for quote_identifier() and pg_dump to not quote keywords

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Yeah. I'm disinclined to pre-emptively quote things for pie-in-the-sky
> patches. WITH is already a grammar keyword, so it's not a big deal to
> tweak things to quote it, but adding a dozen keywords that have zero
> functionality in the grammar is another thing entirely.

Sure.

> Also, the fact that this particular form of the grammar requires
> reserving the keywords does not prove that there is no way to have the
> features without that. I'd want to see us try a little harder first.

At least some of them are unavoidable conflicts:

select a,b,count(*) from tab GROUP BY cube(a,b)
select a,b,count(*) from tab GROUP BY rollup(a,b)

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com