Re: Ryu floating point output patch

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Donald Dong <xdong(at)csumb(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: Ryu floating point output patch
Date: 2019-02-17 16:19:05
Message-ID: 87lg2ejsy8.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>> b) new command-line option, e.g. pg_dump --extra-float-digits=0

>> This is probably the safest option, IMO. Any preferences as to the
>> option name?

Tom> I like that too, assuming that it can be made to fit into the
Tom> structure of the cross-version-upgrade tests (which would have
Tom> to know to use it only with >= v12 pg_dump).

Tom> --extra-float-digits seems fine as a name.

As far as I can tell, test.sh only uses the new version's pg_dump (in
fact the only binaries directly used from the old version are initdb and
pg_ctl).

... wait, this initdb in test.sh is using an option that doesn't exist
before pg11? Is the cross-version test actually using some different
script? Andrew?

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2019-02-17 16:29:56 Re: Actual Cost
Previous Message Tom Lane 2019-02-17 16:09:27 Re: CPU costs of random_zipfian in pgbench