| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Small TAP tests cleanup for Windows and unused modules |
| Date: | 2022-03-25 12:42:18 |
| Message-ID: | 87lewyqk45.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 18 Feb 2022, at 22:02, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> .. let's drop the 0001 from this thread and just go ahead with 0002.
>
> I applied the 0002 patch today, cleaning up the unused module imports.
A quick git grep¹ revealed a few more extraneous `use Config;`
statements (and manual inspection a few more unused modules in one
file). Here's a patch that removes those. It passes tests using
./configure --enable-tap-tests --with-ldap
make check-world PG_TEST_EXTRA=ldap
- ilmari
[1] git grep -L '[%(at)$]Config\b' $(git grep -l 'use Config')
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-more-unused-module-imports-in-test.patch | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2022-03-25 12:52:40 | pg_relation_size on partitioned table |
| Previous Message | Alvaro Herrera | 2022-03-25 12:26:05 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |