| From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Properly pathify the union planner |
| Date: | 2024-02-18 09:07:50 |
| Message-ID: | 87jzn2gmwh.fsf@163.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>>
>> The two if-clauses looks unnecessary, it should be handled by
>> pathkeys_count_contained_in already. The same issue exists in
>> pathkeys_useful_for_ordering as well. Attached patch fix it in master.
>
> I agree. I'd rather not have those redundant checks in
> pathkeys_useful_for_setop(), and I do want those functions to be as
> similar as possible. So I think adjusting it in master is a good
> idea.
>
> I've pushed your patch.
>
Thanks for the pushing!
--
Best Regards
Andy Fan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Luzanov | 2024-02-18 11:14:21 | Re: Things I don't like about \du's "Attributes" column |
| Previous Message | Sutou Kouhei | 2024-02-18 08:38:09 | Re: Why is pq_begintypsend so slow? |