More Perl cleanups

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: More Perl cleanups
Date: 2025-03-14 17:39:30
Message-ID: 87jz8rzf3h.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Hackers,

In some recent-ish commits (ce1b0f9d, fd4c4ede and cc2c9fa6) we
converted a lot of the TAP tests to use long command line options and
fat commas (=>) to separate command line options from their arguments,
so that perltidy does't break lines between them.

However, those patches were nowhere near complete, so here's a follow-up
to fix all the cases I could find. While I was there I failed to resist
the urge to do some other minor tidy-ups that I think make things
neater, but perltidy has no opinion on. I also eliminated some variables
that were only initialised and then used once.

The second patch might be more controversial: it eliminates unnecessary
quoting from hash keys, both inside curly braces and before fat commas
(except where a hash has a mix of keys that need quoting and not).

- ilmari

Attachment Content-Type Size
0001-TAP-tests-use-more-fat-commas-and-long-options.patch text/x-diff 72.2 KB
0002-perl-remove-pointless-quotes-from-hash-keys.patch text/x-diff 64.9 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2025-03-14 17:55:33 Re: Optimization for lower(), upper(), casefold() functions.
Previous Message David E. Wheeler 2025-03-14 16:58:55 PG_CFLAGS rpath Passthrough Issue