Re: Add function dependencies

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Joel Jacobson <joel(at)gluefinance(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add function dependencies
Date: 2011-01-13 10:19:42
Message-ID: 87hbddyukh.fsf@hi-media-techno.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> That seems pretty silly/broken. You should only be touching *direct*
> dependencies of the extension, IMO. If there's something that's missed
> by that algorithm, the way to fix it is to add more direct dependencies
> at extension creation time; not to start a tree walk that is pretty
> nearly guaranteed to land on things that don't belong to the extension.

Well the current patch is walking the tree because that's what I need
for listing extension's objects (in \dx ext), e.g. I want to follow from
an opclass to its functions in that context.

Now I reused this walker for ALTER EXTENSION SET SCHEMA, where it could
well be that I don't need walking down the dependency tree. Will think
about it and try it (very localised change). Thanks for comments.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2011-01-13 10:35:47 Re: Bug in walreceiver
Previous Message Joel Jacobson 2011-01-13 10:13:54 Possible bug in pg_settings/pg_depend