pg_combinebackup PITR comparison test fix

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: pg_combinebackup PITR comparison test fix
Date: 2024-12-14 21:57:11
Message-ID: 87h67653ns.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

While I was going through the TAP tests to fix the formatting of command
argument lists to be less confusing, I noticed that pg_combinebackup's
002_compare_backups.pl test accidentally ran pg_dumpall twice against
the same database, thus rendering the tests useless.

Fixing that revealed that there is a difference in the dumps: the
tablespaces have different paths. pg_dumpall doesn't have an option to
map tablespace paths, so instead I used File::Compare::compare_text()
with a custom comparison function to erase the difference.

- ilmari

Attachment Content-Type Size
0001-Fix-pg_combinebackup-PITR-comparison-test.patch text/x-diff 1.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-12-14 22:08:19 Re: Converting contrib SQL functions to new style
Previous Message Tom Lane 2024-12-14 21:34:30 Re: Converting contrib SQL functions to new style