Re: Assorted typo fixes

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Assorted typo fixes
Date: 2024-01-01 23:05:08
Message-ID: 87frzgmz8b.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Shubham Khanna <khannashubham1197(at)gmail(dot)com> writes:

> I was reviewing the Patch and came across a minor issue that the Patch
> does not apply on the current Head. Please provide the updated version
> of the patch.

Thanks for the heads-up. Commit 5ccb3bb13dcbedc30d015fc06d306d5106701e16
removed one of the instances of "data struture" fixed by the patch.

Rebased patch set attached. I also squashed the check_decls.m4 change
into the main comment typos commit.

> Also, I found one typo:
> 0008-ecpg-fix-typo-in-get_dtype-return-value-for-ECPGd_co.patch All
> the other enum values return a string mathing the enum label, but this
> has had a trailing r since the function was added in commit
> 339a5bbfb17ecd171ebe076c5bf016c4e66e2c0a
>
> Here 'mathing' should be 'matching'.

Thanks. I've fixed the commit message (and elaborated it a bit more why
I think it's a valid and safe fix).

> Thanks and Regards,
> Shubham Khanna.

- ilmari

Attachment Content-Type Size
v2-0001-Fix-typos-in-comments.patch text/x-diff 26.6 KB
v2-0002-tsquery-fix-typo-rewrited-rewritten.patch text/x-diff 2.7 KB
v2-0003-gist-fix-typo-split-t-ed-split.patch text/x-diff 8.5 KB
v2-0004-libpq-fix-typo-occurences-occurrences-in-tests.patch text/x-diff 3.4 KB
v2-0005-jsonpath_exec-fix-typo-absense-absence.patch text/x-diff 2.0 KB
v2-0006-jsonpath_gram-fix-typo-indexs-indices.patch text/x-diff 1.1 KB
v2-0007-pg_archivecleanup-fix-typo-extention-extension-in.patch text/x-diff 1.2 KB
v2-0008-ecpg-fix-typo-in-get_dtype-return-value-for-ECPGd.patch text/x-diff 1.1 KB
v2-0009-ci-fix-typo-in-macports-check-superfluos-superflu.patch text/x-diff 872 bytes
v2-0010-doc-fix-typo-vertexes-vertices.patch text/x-diff 978 bytes
v2-0011-doc-fix-typo-formattings-in-rangedypes-docs.patch text/x-diff 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2024-01-01 23:55:00 Re: Change GUC hashtable to use simplehash?
Previous Message Tom Lane 2024-01-01 21:38:27 Minor cleanup for search path cache