Re: [PATCH] session_replication_role = replica with TRUNCATE

Hi,

On 02/01/18 17:16, Marco Nenciarini wrote:
> Hi,
>
> I've tried to amend the documentation to be more clear. Feel free to
> suggest further editing. Patch v2 attached.
>

I think the patch as is now looks okay. So marking as ready for committer.

This is noteworthy for the release notes though as it's behavior change
compared to old versions.

> Regards,
> Marco
>
> P.S: I'm struggling to understand why we have two possible values of
> session_replication_role settings that behave identically (origin and
> local). I'm unable to see any difference according to the code or the
> documentation, so I'm wondering if we should document that they are the
> same.
>

It's for use by 3rd party tools (afaik both londiste and slony use it)
to differentiate between replicated and not replicated changes.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services