Re: Poorly named support routines for GIN tsearch index opclasses

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Oleg Bartunov" <oleg(at)sai(dot)msu(dot)su>, "Teodor Sigaev" <teodor(at)sigaev(dot)ru>, <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Poorly named support routines for GIN tsearch index opclasses
Date: 2007-11-28 01:03:18
Message-ID: 87d4tv9o6h.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Another possibility would be to change the declared signatures to show
> "tsquery" rather than "internal" at the places where a tsquery argument
> is expected. I'm less excited about that part though.

The use of "internal" arguments has always been the part of GIN/GIST which
bothered me the most. Most of those instances are actually quite necessary but
if there are some that aren't I'm all for removing them.

The only thing is that this has a semantic effect. It means users will be able
to call these functions from SQL directly. Are they safe to allow this? Is
this useful?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's On-Demand Production Tuning

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2007-11-28 01:28:11 Re: Time to update list of contributors
Previous Message Kris Jurka 2007-11-28 00:52:39 Re: [HACKERS] Time to update list of contributors