| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |
| Date: | 2022-08-11 10:38:19 |
| Message-ID: | 87d2e5f8-3c37-d185-4bbc-1de163ac4b10@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.08.22 19:08, Ranier Vilela wrote:
> Like how
> https://github.com/postgres/postgres/commit/9fd45870c1436b477264c0c82eb195df52bc0919
> <https://github.com/postgres/postgres/commit/9fd45870c1436b477264c0c82eb195df52bc0919>
> New attempt to remove more MemSet calls, that are safe.
>
> Attached v3 patch.
Note that struct initialization does not set padding bits. So any
struct that is used as a hash key or that goes to disk or something
similar needs to be set with memset/MemSet instead. Various places in
the code make explicit comments about that, which your patch deletes,
which is a mistake. This patch needs to be adjusted carefully with this
in mind before it can be considered.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | r.zharkov | 2022-08-11 10:40:52 | Re: Checking pgwin32_is_junction() errors |
| Previous Message | Amit Kapila | 2022-08-11 10:33:08 | Re: logical replication restrictions |