Re: Patch to fix write after end of array in hashed agg initialization

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Colm McHugh <colm(dot)mchugh(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch to fix write after end of array in hashed agg initialization
Date: 2019-05-23 04:11:57
Message-ID: 87d0k9dd4u.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
>> My inclination is to fix this in the planner rather than the
>> executor; there seems no good reason to actually hash a duplicate
>> column more than once.

Tom> Sounds reasonable --- but would it make sense to introduce some
Tom> assertions, or other cheap tests, into the executor to check that
Tom> it's not being given a case it can't handle?

Oh definitely, I was planning on it.

--
Andrew (irc:RhodiumToad)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-05-23 05:21:08 Re: nitpick about poor style in MergeAttributes
Previous Message Tom Lane 2019-05-23 04:02:36 Re: Patch to fix write after end of array in hashed agg initialization