| From: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction |
| Date: | 2017-09-12 15:48:18 |
| Message-ID: | 87bmmfuddp.fsf@ars-thinkpad |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
> FWIW, perhaps we can change the replication origin management so that
> DROP SUBSCRIPTION doesn't drop the replication origin and the apply
> worker itself removes it when exit. When an apply worker exits it
> removes the replication origin if the corresponding subscription had
> been removed.
I don't think this is reliable -- what if worker suddenly dies without
accomplishing the job? It is enough to kill the worker during execution
of (possibly long) transaction with DROP SUBSCRIPTION to meet such
situation. Dropping replication origin in one transaction with DROP
SUBSCRIPTION seems natural to me.
--
Arseny Sher
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Elvis Pranskevichus | 2017-09-12 15:48:28 | Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable. |
| Previous Message | Tom Lane | 2017-09-12 15:37:59 | Re: Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b |