From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: TAP test command_fails versus command_fails_like |
Date: | 2025-02-12 17:10:01 |
Message-ID: | 87bjv72iom.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote:
>>>
>>>> Another question is whether command_fails and command_fails_like is
>>>> the only pair or there are more which need stricter checks?
>>> If we do this, we should do it across the board for
>>> PostgreSQL::Test::Utils and ::Cluster at least. Once we bump the
>>> minimum perl version to 5.20 or beyond we should switch to using
>>> function signatures (https://perldoc.perl.org/perlsub#Signatures) which
>>> gives us this checking for free.
>>
>> Is there any reason we can't move to 5.20? Are there any buildfarm
>> animals using such an old version? 5.20 is now almost 10 years old.
>
> Red Hat Enterprise Linux 7 has Perl 5.16 and is on Extended Lifecycle
> Support until 2028-06-30. I don't know how long other distros based on
> that (e.g. CentOS, Scientific Linux) are supported, but I can see that
> Amazon Linux 2 is almost out of support (2025-06-30).
Ah, I found the thread from when we bumped it from 5.8 to 5.14 in 2022,
which has a list of then-current perl versions in the buildfarm:
https://postgr.es/m/20220902190329.jxvdeehkbfnrfmtl%40awork3.anarazel.de
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2025-02-12 17:13:13 | Re: Track the amount of time waiting due to cost_delay |
Previous Message | Andres Freund | 2025-02-12 17:00:03 | Re: Small memory fixes for pg_createsubcriber |