Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system
Date: 2007-08-22 23:36:19
Message-ID: 87absjw39o.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> In the first place, it is considered bad form for a package to install
> an absolute symlink to /usr/share/zoneinfo:
>
> "symlinks _should_ be relative. Even if all they have in common is /."
> - Jeremy Katz
> https://www.redhat.com/archives/fedora-maintainers/2007-August/msg00096.html
>
> Followup arguments in that thread mentioned chroots and NFS mounts as
> environments where absolute symlinks are likely to lead to the wrong
> place.

Fwiw Debian also faced this issue and came to a different conclusion. IIRC the
policy is that it's explicitly supported for a sysadmin to replace any
directory in the top level directory with a symlink. So for example /home ->
/export/home.

Therefore any package which includes a symlink which traverses between top
level directories *must* be absolute. And any symlink which does not span two
top level directories *must* be relative. So /usr/foo/bar which links to
/var/foo/bar must be absolute. But /usr/foo/bar which links to /usr/qux/bar
must be a relative link ../qux/bar.

> In short, then, the patch actually being used (as of today) in Fedora
> and ultimately RHEL is as below, and I don't see any prospect of
> substituting the mechanism Peter has created.

Why would --with-zoneinfo want to use a symlink though? Shouldn't it just
compile the binary to use the path specified directly? Symlinks are fine for a
sysadmin or a packager but if it's going to be supported by Postgres code
directly why not do it directly?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2007-08-22 23:49:46 Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system
Previous Message Tom Lane 2007-08-22 23:03:33 pgsql: Fix possible core dump from pgbench -d option.

Browse pgsql-hackers by date

  From Date Subject
Next Message Ben Tilly 2007-08-22 23:45:31 SQL feature requests
Previous Message Tom Lane 2007-08-22 22:16:22 Re: [COMMITTERS] pgsql: Add configure option --with-system-tzdata to use operating system