From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Tab completion for SET TimeZone |
Date: | 2022-03-18 10:17:00 |
Message-ID: | 87a6dnsgyr.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
>> Also, personally, I'd rather not smash the names to lower case.
>> I think that's a significant decrement of readability.
>
> That was mainly for convenience of not having to capitalise the place
> names when typing (since they are accepted case insensitively). A
> compromise would be to lower-case it in the WHERE, but not in the
> SELECT, as in the attached v3 patch.
I just realised there's no point in the subselect when I'm not applying
the same function in the WHERE and the SELECT, so here's an updated
version that simplifies that. It also fixes a typo in the commit
message.
- ilmari
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Add-tab-completion-for-SET-TimeZone-TO.patch | text/x-diff | 2.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Japin Li | 2022-03-18 10:19:38 | Re: Support logical replication of DDLs |
Previous Message | Julien Rouhaud | 2022-03-18 09:27:49 | Re: pgsql: Add option to use ICU as global locale provider |