Re: ALTER TABLE support for dropping generation expression

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Sergei Kornilov <sk(at)zsrv(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ALTER TABLE support for dropping generation expression
Date: 2019-12-28 17:05:28
Message-ID: 879ef3c3-3302-40b6-715a-b4cb32ba5660@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-12-25 12:01, Sergei Kornilov wrote:
> Patch does not apply to master. Could you rebase?

done

> I noticed one bug:
>
> create table testdrop (i int, b int, m int GENERATED ALWAYS AS ( i*2) stored);
> insert into testdrop(i,b) values (3,4);
> alter table testdrop alter COLUMN m drop expression ;
> alter table testdrop drop column i;
>
> Here is no "m" column anymore. Possible due some forgotten dependency?

fixed -- good catch

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v2-0001-ALTER-TABLE-.-ALTER-COLUMN-.-DROP-EXPRESSION.patch text/plain 18.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2019-12-28 17:19:58 Recognizing superuser in pg_hba.conf
Previous Message Vik Fearing 2019-12-28 16:58:52 Greatest Common Divisor