| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "Teodor Sigaev" <teodor(at)sigaev(dot)ru> |
| Cc: | <andrew(at)supernews(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIST and TOAST |
| Date: | 2007-03-06 23:36:39 |
| Message-ID: | 878xea9c6w.fsf@stark.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Teodor Sigaev" <teodor(at)sigaev(dot)ru> writes:
>> It doesn't actually crash, it just fails CHECKARRVALID. I added an assertion
>> in there to cause it to generate a core dump.
>
> Wow, catch that, see attached patch.
>
> g_int_decompress doesn't returns detoasted array in case it was empty.
> Previously it was safe because empty array never has been toasted.
Ah, thanks a bunch.
> Should I commit it or you'll include in your patch?
I'll include it in the patch I guess since it's fine the way it is until the
patch hits.
Now I'll try running the regressions again with the gist datatypes like hstore
etc all packed as well.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2007-03-07 00:28:03 | Re: Bug: Buffer cache is not scan resistant |
| Previous Message | Tom Lane | 2007-03-06 23:23:58 | Re: Plan invalidation vs. unnamed prepared statements |