| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz> |
| Subject: | Re: Abbreviated keys for Numeric |
| Date: | 2015-04-03 13:06:42 |
| Message-ID: | 878ue9wee9.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Robert" == Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> No, that's wrong; it must use USE_FLOAT8_BYVAL since that's what the
>> definitions of Int64GetDatum / DatumGetInt64 are conditional on. As
>> you have it now, it'll break if you build with
>> --disable-float8-byval on a 64bit platform.
Robert> I'd prefer to avoid that by avoiding the use of those macros in
Robert> this code path rather than by leaving the top 32 bits of the
Robert> Datum unused
I don't consider it appropriate to override ./configure in this way.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2015-04-03 13:46:45 | Re: PATCH: adaptive ndistinct estimator v4 |
| Previous Message | Peter Geoghegan | 2015-04-03 13:04:26 | Re: Abbreviated keys for text cost model fix |