| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SSL SNI |
| Date: | 2021-06-07 15:34:24 |
| Message-ID: | 878795.1623080064@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> Patch attached. Empty host string was handled implicitly by the IP
> detection expression, but I added an explicit check for sanity. (I
> wasn't actually able to get an empty string to this point, but it's
> clearly better to be prepared for it.)
Yeah, I'd include the empty-string test just because it's standard
practice in this area of libpq. Whether those tests are actually
triggerable in every case is obscure, but ...
Patch looks sane by eyeball, though I didn't test it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-06-07 15:37:58 | Re: libpq debug log |
| Previous Message | Tom Lane | 2021-06-07 15:27:41 | Re: SQL-standard function body |