Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: PATH manipulation in 001_libpq_pipeline.pl fails on windows
Date: 2021-10-01 18:07:42
Message-ID: 87875257-f359-4480-a709-88c58b7497c5@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 9/30/21 5:40 PM, Andres Freund wrote:
> Hi,
>
> For me 001_libpq_pipeline.pl doesn't reliably work on windows, because it
> tries to add something to PATH, using unix syntax (vs ; used on windows).
>
> $ENV{PATH} = "$ENV{TESTDIR}:$ENV{PATH}";
>
> If the first two elements in PATH are something needed, this can cause the
> test to fail... I'm surprised this doesn't cause problems on the buildfarm - a
> plain
> perl src\tools\msvc\vcregress.pl taptest src\test\modules\libpq_pipeline\
> fails for me.

Not sure. That's certainly an error.

But why are we mangling the PATH at all? Wouldn't it be better just to
call command_ok with "$ENV{TESTDIR}/libpg_pipeline" ?

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-10-01 18:15:53 Re: 2021-09 Commitfest
Previous Message Bossart, Nathan 2021-10-01 18:05:36 Re: parallelizing the archiver