| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, emre(at)hasegeli(dot)com |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve geometric types |
| Date: | 2018-08-17 21:01:58 |
| Message-ID: | 87846de5-9dbe-85d9-96c3-d01bd6249d37@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/17/2018 08:56 PM, Tom Lane wrote:
> Emre Hasegeli <emre(at)hasegeli(dot)com> writes:
>>> BTW how did we end up with the regression differences? Presumably you've
>>> tried that on your machine and it passed. So if we adjust the expected
>>> file, won't it fail on some other machines?
>
>> I had another patch to check for -0 inside float{4,8}_{div,mul}(). I
>> dropped it on the last set of patches, so the tests were broken. I
>> get -0 as a result of -x * 0 both on Mac and Linux.
>
> I'll bet a good deal of money that you'll find that does not hold
> true across the whole buildfarm.
>
Hmm, yeah. Based on past experience, the powerpc machines are likely to
stumble on this.
FWIW my understanding is that these failures actually happen in new
tests, it's not an issue introduced by this patch series.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2018-08-17 21:12:42 | Re: docs: note ownership requirement for refreshing materialized views |
| Previous Message | Alexander Korotkov | 2018-08-17 20:38:50 | Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept |