From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Possible bug: SQL function parameter in window frame definition |
Date: | 2019-10-02 15:24:05 |
Message-ID: | 877e5n2n70.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
[moving to -hackers, removing OP and -general]
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
Tom> Also, in HEAD I'd be inclined to add assertions about utilityStmt
Tom> being NULL.
Tried this. The assertion is hit:
#3 0x0000000000bb9144 in ExceptionalCondition (conditionName=0xd3c7a9 "query->utilityStmt == NULL",
errorType=0xc3da24 "FailedAssertion", fileName=0xd641f8 "nodeFuncs.c", lineNumber=2280) at assert.c:54
#4 0x000000000081268e in query_tree_walker (query=0x80bb34220, walker=0x98d150 <rangeTableEntry_used_walker>,
context=0x7fffffffc768, flags=0) at nodeFuncs.c:2280
#5 0x0000000000815a29 in query_or_expression_tree_walker (node=0x80bb34220, walker=0x98d150 <rangeTableEntry_used_walker>,
context=0x7fffffffc768, flags=0) at nodeFuncs.c:3344
#6 0x000000000098d13d in rangeTableEntry_used (node=0x80bb34220, rt_index=1, sublevels_up=0) at rewriteManip.c:900
#7 0x0000000000698ce6 in transformRuleStmt (stmt=0x80241bd20,
queryString=0x80241b120 "create rule r3 as on delete to rules_src do notify rules_src_deletion;", actions=0x7fffffffc968,
whereClause=0x7fffffffc960) at parse_utilcmd.c:2883
#8 0x00000000009819c5 in DefineRule (stmt=0x80241bd20,
queryString=0x80241b120 "create rule r3 as on delete to rules_src do notify rules_src_deletion;") at rewriteDefine.c:206
Any suggestions where best to fix this? transformRuleStmt could be
taught to skip a lot of the per-Query stuff it does in the event that
the Query is actually a NOTIFY, or a check for NOTIFY could be added
further down the stack, e.g. in rangeTableEntry_used. Any preferences?
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-10-02 15:32:51 | Re: Possible bug: SQL function parameter in window frame definition |
Previous Message | PegoraroF10 | 2019-10-02 14:37:43 | Performance on JSONB select |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-10-02 15:32:51 | Re: Possible bug: SQL function parameter in window frame definition |
Previous Message | Robert Haas | 2019-10-02 15:22:19 | Re: let's make the list of reportable GUCs configurable (was Re: Add %r substitution for psql prompts to show recovery status) |