| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: plpgsql-trigger.html: Format TG_ variables as table (patch) |
| Date: | 2022-08-31 14:19:50 |
| Message-ID: | 877d2omr5l.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Christoph Berg <myon(at)debian(dot)org> writes:
> Re: To Daniel Gustafsson
>> "string containing" is again pretty boilerplatish, how about just
>> "contains"?
>
> Actually, just omitting the whole prefix works best.
>
> TG_WHEN (text)
>
> BEFORE, AFTER, or INSTEAD OF, depending on the trigger's definition.
The attached patch does not reflect this, did you attach an old version?
> I also shortened some "name of table" to just "table". Since the data
> type is "name", it's clear what "table" means.
I think it reads better with the definite article and initial capital,
e.g. "The table that triggered ….".
> <variablelist>
> <varlistentry>
> - <term><varname>NEW</varname></term>
> + <term><varname>NEW</varname> (record)</term>
The type names should still be wrapped in <type>, like they were before.
- ilmari
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-08-31 14:20:24 | Re: SQL/JSON features for v15 |
| Previous Message | Justin Pryzby | 2022-08-31 14:01:28 | pg15b3: recovery fails with wal prefetch enabled |