| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should contrib modules install .h files? |
| Date: | 2018-08-02 18:13:05 |
| Message-ID: | 87600sabb2.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Andrew" == Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
Tom> There's also a question of whether we need to change anything in
Tom> contrib/ so that it plays by whatever rules we set. There's an
Tom> expectation that contrib modules should be buildable with PGXS,
Tom> so they need to follow the rules.
Andrew> ... that at least all of the *_plperl transform modules in
Andrew> contrib/ fail to build with USE_PGXS already (i.e. for as long
Andrew> as they have ever existed), because they rely on
Andrew> plperl_helpers.h which is never installed anywhere, and trying
Andrew> to get it via $(top_srcdir) obviously can't work in PGXS.
Andrew> Haven't tried the python ones yet.
And none of the plpython transforms can even parse their makefiles with
USE_PGXS, let alone build, because they have an "include" directive
pointing into src/pl/plpython.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-08-02 18:21:44 | Re: Should contrib modules install .h files? |
| Previous Message | Alexander Korotkov | 2018-08-02 18:06:20 | Re: [HACKERS] Bug in to_timestamp(). |