Re: Potentially misleading name of libpq pass phrase hook

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Potentially misleading name of libpq pass phrase hook
Date: 2020-05-16 01:21:52
Message-ID: 875071bd-4642-5e50-76d2-78cfbc1968bc@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/15/20 8:21 PM, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, May 14, 2020 at 3:03 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> Since we haven't shipped this there is still time to rename, which IMO
>>> is the right way forward. PQsslKeyPassHook_<library>_type would be one
>>> option, but perhaps there are better alternatives?
>
>> ISTM this should be renamed yeah -- and it should probably go on the open
>> item lists, and with the schedule for the beta perhaps dealt with rather
>> urgently?
>
> +1. Once beta1 is out the cost to change the name goes up noticeably.
> Not that we *couldn't* do it later, but it'd be better to have it be
> right in beta1.

+1 on all of the above.

I noticed this has been added to Open Items; I added a note that the
plan is to fix before the Beta 1 wrap.

Jonathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2020-05-16 01:24:03 Re: PostgreSQL 13 Beta 1 Release: 2020-05-21
Previous Message Michael Paquier 2020-05-16 01:15:47 Re: pg_stat_wal_receiver and flushedUpto/writtenUpto