| From: | Greg Stark <gsstark(at)mit(dot)edu> | 
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> | 
| Cc: | Greg Stark <gsstark(at)mit(dot)edu>, Stephan Szabo <sszabo(at)megazone(dot)bigpanda(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org | 
| Subject: | Re: Collation rules and multi-lingual databases | 
| Date: | 2003-08-23 19:34:21 | 
| Message-ID: | 874r08goci.fsf@stark.dyndns.tv | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Joe Conway <mail(at)joeconway(dot)com> writes:
> >   if (sigsetjmp(Warn_restart, 1) != 0)
> >   {
> >     memcpy(&Warn_restart, &save_restart, sizeof(Warn_restart));
> >     newlocale = setlocale(LC_COLLATE, oldlocale);
> >     if (!newlocale)
> >       elog(PANIC, "setlocale failed to reset locale: %s", localestr);
> >     siglongjmp(Warn_restart, 1);
> >   }
Well presumably we want FATAL not PANIC.
And do we still need HOLD_INTERRUPTS() .. RESUME_INTERRUPTS() ?
I was afraid that was getting into bed too much with the error handling. I
have an implementation that restores the locale around the palloc and
increases the initial guess for future calls to avoid degenerate behaviour.
I'm not sure which approach is preferable.
-- 
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2003-08-23 19:42:06 | Re: ambiguous sql states | 
| Previous Message | Peter Eisentraut | 2003-08-23 19:16:38 | Re: Header files installed for contrib modules? |