Re: 7.4.1 release status - Turkish Locale

From: Greg Stark <gsstark(at)mit(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: 7.4.1 release status - Turkish Locale
Date: 2004-02-09 21:45:21
Message-ID: 874qu0lyfi.fsf@stark.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Greg Stark <gsstark(at)mit(dot)edu> writes:
> > If it matches an SQL keyword after being downcased the old fashioned way, then
> > it's an SQL keyword. If not then the locale-aware tolower() would be
> > appropriate for tables, columns, etc.
>
> That's exactly what we do already. The complaint was that the
> locale-aware downcasing is broken (not to put it too finely) in Turkish
> locales, leading to unexpected/unwanted results for identifiers that are
> not keywords.

But the example given was "SERIAL". "serial" is an English word, not a Turkish
word. It shouldn't really be subject to Turkish locale effects at all. Perhaps
"keyword" wasn't the right word in my message.

I'm wondering if he really expects all identifiers to be subject to this ascii
downcasing. Like, if he had a GÜNAYDIN column he might be surprised to when
günaydýn (where ý is the lowercase dotless i) says column "günaydýn" doesn't
exist.

Or is the real problem simply that both styles of i really ought to match all
the time, ie, that they should really be considered the same letter for
matches? I wonder if there are other locales where that's an issue.

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-02-09 22:10:01 Re: 7.4.1 release status - Turkish Locale
Previous Message Vsevolod Lobko 2004-02-09 21:28:31 Re: CVS HEAD compile failure on Freebsd 4.9