Re: Broken code in recent troff commit

From: Roger Leigh <rleigh(at)whinlatter(dot)ukfsn(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgreSQL(dot)org
Subject: Re: Broken code in recent troff commit
Date: 2005-06-09 18:47:13
Message-ID: 874qc74bbi.fsf@hardknott.home.whinlatter.ukfsn.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> print.c line 1009:
> fputs("\(rs", fout);
>
> is sufficiently obviously wrong that even my ancient HPUX C compiler is
> unhappy. I don't know troff, though, so I don't know if "\\(rs" was
> meant or something else.

Sorry about that. I'm not sure why GCC didn't pick that up. Troff
uses "\(rs" to produce a backslash ("Right Slash"), so "\\(rs" will be
correct. I've double checked the rest of the diff, and that's the
only instance of a missing '\'.

Regards,
Roger

- --
Roger Leigh
Printing on GNU/Linux? http://gimp-print.sourceforge.net/
Debian GNU/Linux http://www.debian.org/
GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8 <http://mailcrypt.sourceforge.net/>

iD8DBQFCqI6wVcFcaSW/uEgRAvVKAKDLg7ndWV7qoTV3y+Cs8NA2xAXlPQCg9YfQ
OZSJZHnbPTtthHpslRQUf7U=
=cGHq
-----END PGP SIGNATURE-----

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-06-09 20:02:01 Re: PQgetGetCopyData() doc. and PQsendQueryGuts() SegFault handling fix.
Previous Message Bruce Momjian 2005-06-09 18:41:18 Re: Broken code in recent troff commit