| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: debug_sortsupport GUC? |
| Date: | 2015-03-23 01:59:38 |
| Message-ID: | 874mpcbhom.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Peter" == Peter Geoghegan <pg(at)heroku(dot)com> writes:
>> So if these debugging elogs are to be kept at all, I propose that
>> rather than being compile-time options they should be controlled by
>> a debug_sortsupport GUC. Opinions?
Peter> This seems like a reasonable idea. Why wouldn't it just be under
Peter> the existing trace_sort GUC, though? That's been enabled by
Peter> default since 8.1. It's already defined in pg_config_manual.h.
Ungh... yes, it's defined by default, but it clearly still requires
keeping the #ifdefs in there in order to still build if someone manually
undefines it. Was hoping to avoid the #ifdefs entirely - perhaps the
existing #ifdefs should just be removed? If it's been enabled since 8.1
it seems unlikely to be causing anyone any issues.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-03-23 02:10:26 | Re: Abbreviated keys for Numeric |
| Previous Message | Andrew Gierth | 2015-03-23 01:52:35 | Re: Abbreviated keys for Numeric |