Re: PG 16 draft release notes ready

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG 16 draft release notes ready
Date: 2023-05-30 10:28:24
Message-ID: 874jnut8on.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:

> On Sat, May 27, 2023 at 09:34:37PM -0400, Bruce Momjian wrote:
>> > > This is controlled by auto_explain.log_parameter_max_length, and by
>> > > default query parameters will be logged with no length
>> > > restriction. SHOULD THIS BE MORE CLEARLY IDENTIFIED AS CONTROLLING THE
>> > > EXECUTION OF PREPARED STATEMENTS?
>> >
>> > This is wrong, the logging applies to all query parameters, not just for
>> > prepared statements (and has nothing to do with controlling the
>> > execution thereof). That was just the only way to test it when it was
>> > written, because psql's \bind command exist yet then.
>>
>> I see your point. How is this?
>>
>> Allow auto_explain to log query parameters used by parameterized
>> statements (Dagfinn Ilmari Mannsåker)
>>
>> This affects queries using server-side PRAPARE/EXECUTE
>> and client-side parse/bind. Logging is controlled by
>> auto_explain.log_parameter_max_length; by default query
>> parameters will be logged with no length restriction.
>
> Done, attached patch applied.

That works for me. Thanks!

- ilmari

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2023-05-30 10:33:09 Re: PG 16 draft release notes ready
Previous Message Bruce Momjian 2023-05-30 10:03:19 Re: PG 16 draft release notes ready