From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: the s_lock_stuck on perform_spin_delay |
Date: | 2024-01-22 17:31:59 |
Message-ID: | 874jf5w9wa.fsf@163.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Jan 22, 2024 at 12:13 PM Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
>> > On Mon, Jan 22, 2024 at 11:58 AM Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
>> >> I get your point! Acquiring an already held spinlock in quickdie is
>> >> unlikely to happen, but since our existing infrastructure can handle it,
>> >> then there is no reason to bypass it.
>> >
>> > No, the existing infrastructure cannot handle that at all.
>>
>> Actually I mean we can handle it without 0003. am I still wrong?
>> Without the 0003, if we acquiring the spin lock which is held by
>> ourself already. VerifyNoSpinLocksHeld in SpinLockAcquire should catch
>> it.
>
> But that's only going to run in assert-only builds. The whole point of
> the patch set is to tell developers that there are bugs in the code
> that need fixing, not to catch problems that actually occur in
> production.
I see. As to this aspect, then yes.
--
Best Regards
Andy Fan
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2024-01-22 17:52:25 | Re: Network failure may prevent promotion |
Previous Message | Robert Haas | 2024-01-22 17:25:14 | Re: the s_lock_stuck on perform_spin_delay |