| From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
|---|---|
| To: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Document for wal_log_hints |
| Date: | 2024-11-19 01:03:57 |
| Message-ID: | 874j449gqq.fsf@163.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When I read the document for wal_log_hints, I see:
<para>
If data checksums are enabled, hint bit updates are always WAL-logged
and this setting is ignored. You can use this setting to test how much
extra WAL-logging would occur if your database had data checksums
enabled.
</para>
I think if it should be changed to ".. if your database had data
checksums *disabled*".
Per my check, wal_log_hints is not used except the case:
#define XLogHintBitIsNeeded() (DataChecksumsEnabled() || wal_log_hints)
So if data checksums is enabled, nothing can be tested when turning
wal_log_hints on/off.
--
Best Regards
Andy Fan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-doc-correct-the-method-to-test-the-impact-of-wal_.patch | text/x-diff | 842 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-11-19 01:09:57 | Re: fix deprecation mention for age() and mxid_age() |
| Previous Message | Masahiko Sawada | 2024-11-19 01:02:41 | Re: Make COPY format extendable: Extract COPY TO format implementations |