From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us (Tom Lane), "David E(dot) Wheeler" <david(at)kineticode(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: updated hstore patch |
Date: | 2009-09-22 01:16:36 |
Message-ID: | 873a6feq2z.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>> On Sep 21, 2009, at 4:57 PM, Andrew Gierth wrote:
>>> I don't think there's any way to do that from the regression tests.
>> The output that you demonstrated a few messages back should do nicely
>> for delete(), at least:
Tom> Anything involving 'explain verbose' output is not getting into the
Tom> regression tests. It's not stable enough.
Tom> In practice, I don't see why simply testing the result of the
Tom> function isn't enough for this...
Is delete('...'::hstore,'foo') guaranteed to resolve to the same
function as delete('...'::hstore,$1) where $1 has no type specified?
If so, then the regression tests already cover this.
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-09-22 01:18:53 | Re: updated hstore patch |
Previous Message | Tom Lane | 2009-09-22 01:09:14 | Re: updated hstore patch |