From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Possible bug: SQL function parameter in window frame definition |
Date: | 2019-10-02 16:20:11 |
Message-ID: | 8736gb2kct.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
Tom> Hm. transformRuleStmt already does special-case utility statements
Tom> to some extent, so my inclination would be to make it do more of
Tom> that. However, it looks like that might end up with rather
Tom> spaghetti-ish code, as that function is kind of messy already.
Tom> Or we could abandon the notion of adding the assertion. I don't
Tom> know how much work it's worth.
Fixing transformRuleStmt just pushes the issue along another step:
InsertRule wants to do recordDependencyOnExpr on the rule actions,
which just does find_expr_references_walker.
I'm going to leave the assertion out for now and put in a comment for
future reference.
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-10-02 16:31:15 | Re: Possible bug: SQL function parameter in window frame definition |
Previous Message | Michael Lewis | 2019-10-02 16:13:08 | Re: Performance on JSONB select |
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Nelson | 2019-10-02 16:22:33 | Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays |
Previous Message | Tom Lane | 2019-10-02 16:03:05 | Re: WIP: Generic functions for Node types using generated metadata |