Re: Dead code as a result of plan cache invalidation?

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code as a result of plan cache invalidation?
Date: 2007-07-04 17:08:43
Message-ID: 871wfocd0k.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Gregory Stark <stark(at)enterprisedb(dot)com> writes:
>> Should this case at heaptuple.c:1606 be turned into an elog() now that we have
>> plan cache invalidation?
>
> No, I think it's good as-is. Reading the column as null is the correct
> behavior.

Isn't the correct behaviour that you would have been prevented from executing
that plan and forced to replan your query?

Let me put it another way, how would I write a test case to cover these lines
of code and not receive an error from replanning?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-07-04 17:18:06 Re: what is difference between LOCAL and GLOBAL TEMP TABLES in PostgreSQL
Previous Message Tom Lane 2007-07-04 16:24:03 Re: Dead code as a result of plan cache invalidation?