From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
---|---|
To: | "Magnus Hagander" <magnus(at)hagander(dot)net> |
Cc: | "pgsql-patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: msvc const warnings |
Date: | 2007-07-24 13:57:37 |
Message-ID: | 871wex3nvy.fsf@oxford.xeocode.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
"Magnus Hagander" <magnus(at)hagander(dot)net> writes:
> Stefan mentioned that the warning may be one that shows up in a different
> compiler somewhere as well, thouh, which might indicate that we should fix
> the underlying issue? (Even if the code is correct, if it confuses multiple
> compilers...)
I think the right fix is just to remove the const qualifier. It's clearly not
treating the pointer as const if it's passing it to pfree which is surely a
state change if anything is.
We do far too much casting to (void*) as it is and I would dearly love to go
through the whole source tree and remove all the redundant casts. All they do
is cover up real type clash bugs.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-07-24 13:59:15 | Re: plperl warnings on win32 |
Previous Message | Tom Lane | 2007-07-24 13:55:57 | Re: plperl warnings on win32 |