Re: Why do we have perl and sed versions of Gen_dummy_probes?

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Re: Why do we have perl and sed versions of Gen_dummy_probes?
Date: 2021-05-10 11:16:12
Message-ID: 871raeon43.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:

> On 07.05.21 20:31, Andrew Dunstan wrote:
>> On 5/7/21 1:20 PM, Andres Freund wrote:
>>> On 2021-05-07 11:19:02 -0400, Andrew Dunstan wrote:
>>>> Here's a patch that adds the README and also adds a Makefile recipe for
>>>> regenerating Gen_dummy_probes.pl after the sed script is changed. On my
>>>> system at least the recipe is idempotent.
>>> Nice! Thanks for this work.
>>
>> de nada. pushed.
>
> This recipe doesn't produce a Gen_dummy_probes.pl that matches exactly
> the one that is there now. If this is going to be the preferred method,
> then we should generate it once so that it matches going forward.

Which version of perltidy do you have installed? For me it generates
identical versions using any of 20170521 (per src/tools/pgindent/README),
20201207 (what I happened to have installed before), and 20210402 (the
latest).

Also, what does the difference look like?

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2021-05-10 11:21:24 Re: seawasp failing, maybe in glibc allocator
Previous Message Thomas Munro 2021-05-10 10:52:24 Re: seawasp failing, maybe in glibc allocator