Re: pgsql: Extend cube on-disk format to pack points more tightly.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Extend cube on-disk format to pack points more tightly.
Date: 2013-10-22 06:45:52
Message-ID: 8711.1382424352@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
> This patch deliberately doesn't update all the alternative expected output
> files, as I don't have access to machines that produce those outputs. I'm
> not sure if they are still relevant, but if they are, the buildfarm will
> tell us and produce the diff required to fix it. If none of the buildfarm
> animals need them, they should be removed altogether.

dugong, for one, doesn't like this patch.

My usual habit for fixing alternative expected files is to apply the same
diff to those files as I got for the one my machine produces. While this
occasionally doesn't work (when there are changes in the unportable
results as well as the portable ones), it works 90% of the time, whereas
your approach here works zero percent of the time.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2013-10-22 11:05:51 pgsql: Make use of psprintf() in recent changes
Previous Message Heikki Linnakangas 2013-10-22 06:41:51 pgsql: Adjust cube.out expected output for new test queries.