| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Verite <daniel(at)manitou-mail(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add standard collation UNICODE |
| Date: | 2023-05-08 15:48:09 |
| Message-ID: | 86c5b4c4-0ccf-0996-8fb8-24d348eabe13@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.04.23 13:44, Daniel Verite wrote:
> This collation has an empty pg_collation.collversion column, instead
> of being set to the same value as "und-x-icu" to track its version.
> The original patch implements this as an INSERT in which it would be easy to
> fix I guess, but in current HEAD it comes as an entry in
> include/catalog/pg_collation.dat:
>
> { oid => '963',
> descr => 'sorts using the Unicode Collation Algorithm with default
> settings',
> collname => 'unicode', collprovider => 'i', collencoding => '-1',
> colliculocale => 'und' },
>
> Should it be converted back into an INSERT or better left
> in this file and collversion being updated afterwards?
How about we do it with an UPDATE command. We already do this for
pg_database in a similar way. See attached patch.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-initdb-Set-collversion-for-standard-collation-UNICOD.patch | text/plain | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-05-08 15:56:48 | Re: Memory leak from ExecutorState context? |
| Previous Message | Melih Mutlu | 2023-05-08 15:41:26 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |