Re: Allow specifying a dbname in pg_basebackup connection string

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jelte Fennema <me(at)jeltef(dot)nl>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Tristen Raab <tristen(dot)raab(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jelte Fennema <github-tech(at)jeltef(dot)nl>
Subject: Re: Allow specifying a dbname in pg_basebackup connection string
Date: 2024-11-04 18:34:57
Message-ID: 86622C5F-DDA5-46D8-B4CD-99429FA8CA35@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Nov 2024, at 18:14, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> perhaps under the illusion that dbname and connection_string can't
> both be NULL.

Ugh, yes, I failed to capture that nuance.

> I think the attached will fix it, but I wonder if there are edge
> cases I'm not thinking of.

+1 on your patch, reading through I can't see anything it misses. Maybe a
comment above the change with a note on why dbname is tested for NULL there
would be good?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-11-04 18:49:45 Re: pg_dump --no-comments confusion
Previous Message Masahiko Sawada 2024-11-04 18:34:28 Re: New "raw" COPY format