Re: Unable parse a comment in gram.y

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unable parse a comment in gram.y
Date: 2024-06-23 04:41:29
Message-ID: 863425.1719117689@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>> I was unable to parse a comment in src/backend/parser/gram.y around line
>> 11364:
>>
>> * As func_expr but does not accept WINDOW functions directly (they
>> * can still be contained in arguments for functions etc.)

> The "but" is required, add a comma before it. It could also be written a
> bit more verbosely:

Perhaps s/As func_expr/Like func_expr/ would be less confusing?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2024-06-23 04:58:15 RE: Pgoutput not capturing the generated columns
Previous Message Tatsuo Ishii 2024-06-23 04:22:10 Re: Unable parse a comment in gram.y