Re: issue with meson builds on msys2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: issue with meson builds on msys2
Date: 2023-04-26 15:30:22
Message-ID: 863239.1682523022@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> If I redirect the output to a file (which is what the buildfarm client
> actually does), it seems like it completes successfully, but I still get
> a non-zero exit:

> pgrunner(at)EC2AMAZ-GCB871B UCRT64 ~/bf
> $ /usr/bin/perl -e 'chdir "root/HEAD/instkeep.2023-04-25_11-09-41";
> system("bin/pg_ctl -D data-C -l logfile stop > stoplog 2>&1") ; print
> "BANG\n" if $?; '
> BANG

> pgrunner(at)EC2AMAZ-GCB871B UCRT64 ~/bf
> $ cat root/HEAD/instkeep.2023-04-25_11-09-41/stoplog
> waiting for server to shut down.... done
> server stopped

Thats ... just wacko. do_stop() emits "waiting for server to shut
down...", "done", and "server stopped" in the same way (via print_msg).
How is it that all three messages show up in one context but not the
other? Could wait_for_postmaster_stop or get_pgpid be bollixing the
stdout channel somehow? Try redirecting stdout and stderr separately
to see if that proves anything.

> It seems more than odd that we get to where the "server stopped" massage
> is printed but we get a failure.

Indeed, that's even weirder. do_stop() returns directly to the
exit(0) in main().

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2023-04-26 19:10:09 Re: issue with meson builds on msys2
Previous Message Andrew Dunstan 2023-04-26 15:11:33 Re: issue with meson builds on msys2

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-04-26 16:51:46 Re: Autogenerate some wait events code and documentation
Previous Message Dimos Stamatakis 2023-04-26 15:24:37 Re: Fix for visibility check on 14.5 fails on tpcc with high concurrency