From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] document |
Date: | 2021-10-04 06:18:04 |
Message-ID: | 8626d9ae-dd6a-ae44-2fd6-f753c4f61534@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021/08/26 1:39, Justin Pryzby wrote:
> On Wed, Aug 25, 2021 at 09:50:13AM -0400, Tom Lane wrote:
>> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>>> When I applied the patch to the master, I found that the table entries for
>>> those function were added into the table for aclitem functions in the docs.
>>> I think this is not valid position and needs to be moved to the proper one
>>> (maybe the table for system catalog information functions?).
>>
>> You have to be very careful these days when applying stale patches to
>> func.sgml --- there's enough duplicate boilerplate that "patch' can easily
>> be fooled into dumping an addition into the wrong place. I doubt that
>> the submitter meant the doc addition to go there.
>
> I suppose one solution to this is to use git format-patch -U11 or similar, at
> least for doc/
Yes. I moved the desriptions of the function into the table for
system catalog information functions, and made the patch by using
git diff -U6. Patch attached. Barring any objection, I'm thinking
to commit it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
doc-pg-char-encoding-funcs_v2.patch | text/plain | 3.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2021-10-04 07:12:49 | Re: Triage on old commitfest entries |
Previous Message | Amit Kapila | 2021-10-04 05:31:24 | Re: Skipping logical replication transactions on subscriber side |