| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea) |
| Date: | 2017-03-04 19:42:23 |
| Message-ID: | 85b5c036-436b-d534-c265-cb1d1bbca07a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/4/17 12:39, Tomas Vondra wrote:
>> Can we have a test case for page_checksum(), or is that too difficult to
>> get running deterministicly?
>
> I'm not sure it can be made deterministic. Certainly not on heap pages,
> because then it'd be susceptible to xmin/xmax changes, but we have other
> bits that change even on index pages (say pd_lsn).
>
> So I'm afraid that's not going to fly.
Then just run it and throw away the result. See sql/page.sql for some
examples.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-04 19:49:36 | Re: Change in "policy" on dump ordering? |
| Previous Message | Peter Geoghegan | 2017-03-04 18:52:44 | Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements |