| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, peter(dot)eisentraut(at)2ndquadrant(dot)com, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication and SIGHUP |
| Date: | 2017-04-10 12:46:29 |
| Message-ID: | 854c8154-beef-45ea-9cee-cf237a297f05@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/04/17 14:40, Tom Lane wrote:
> Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> writes:
>> Looks good to me. Just as a note, we'll have to handle this newly
>> supported config rereads in the async commit patch where we override
>> synchronous_commit GUC, but the config reread will change it back.
>
> Umm ... you're doing what?
>
We are doing:
+ SetConfigOption("synchronous_commit",
+ MySubscription->synccommit ?
"local" : "off",
+ PGC_BACKEND, PGC_S_OVERRIDE);
> There are mechanisms for making local changes to a GUC. Just stomping
> on the variable is not an approved way to do it.
>
I don't remember from top of my head if above is safe enough against
config reread or not, hence the note.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2017-04-10 12:57:36 | Re: Letting the client choose the protocol to use during a SASL exchange |
| Previous Message | Tom Lane | 2017-04-10 12:40:21 | Re: logical replication and SIGHUP |