| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | Re: speed up a logical replica setup |
| Date: | 2024-01-25 09:27:21 |
| Message-ID: | 85273fe9-8421-45e4-903d-abdeb8607ff8@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.01.24 00:44, Euler Taveira wrote:
> Subscriber has a different meaning of subscription. Subscription is an SQL
> object. Subscriber is the server (node in replication terminology) where the
> subscription resides. Having said that pg_createsubscriber doesn't seem
> a bad
> name because you are creating a new subscriber. (Indeed, you are
> transforming /
> converting but "create" seems closer and users can infer that it is a
> tool to
> build a new logical replica.
That makes sense.
(Also, the problem with "convert" etc. is that "convertsubscriber" would
imply that you are converting an existing subscriber to something else.
It would need to be something like "convertbackup" then, which doesn't
seem helpful.)
> I think "convert" and "transform" fit for this case. However, "create",
> "convert" and "transform" have 6, 7 and 9 characters, respectively. I
> suggest
> that we avoid long names (subscriber already has 10 characters). My
> preference
> is pg_createsubscriber.
That seems best to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-01-25 09:39:11 | Re: Fix inappropriate comments in function ReplicationSlotAcquire |
| Previous Message | Wei Wang (Fujitsu) | 2024-01-25 09:26:42 | Fix inappropriate comments in function ReplicationSlotAcquire |