| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Neil Conway" <neilc(at)samurai(dot)com> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Remove inappropriate memory context switch in |
| Date: | 2008-11-30 21:09:18 |
| Message-ID: | 8519.1228079358@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
"Neil Conway" <neilc(at)samurai(dot)com> writes:
> On Sun, Nov 30, 2008 at 10:49 AM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
>> Remove inappropriate memory context switch in shutdown_MultiFuncCall().
> I added that context switch for a reason:
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00153.php
Hm, too bad you didn't respond to my message inquiring about this a
couple days ago.
> Presumably that's why the build farm is crashing on dblink.
I'll take a look in a bit. However, the switch in the shutdown function
was simply wrong, because it was *not* "returning to the caller's
context". I suspect what this really says is dblink is doing something
it shouldn't.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Conway | 2008-11-30 21:26:17 | Re: pgsql: Remove inappropriate memory context switch in |
| Previous Message | Neil Conway | 2008-11-30 21:03:29 | Re: pgsql: Remove inappropriate memory context switch in |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2008-11-30 21:19:12 | Re: Windowing Function Patch Review -> Standard Conformance |
| Previous Message | Neil Conway | 2008-11-30 21:03:29 | Re: pgsql: Remove inappropriate memory context switch in |