Re: BUG #14775: Incorrect documentation for the Commit logical replication message format

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, kyle(at)kyleconroy(dot)com
Cc: pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #14775: Incorrect documentation for the Commit logical replication message format
Date: 2017-08-14 17:45:06
Message-ID: 84fe26d6-5a46-2064-0cce-f0067f299517@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 8/10/17 04:21, Masahiko Sawada wrote:
>> The Commit message format is incorrectly documented. The `flags` field[0] is
>> missing. I ran into this while creating a parser for the messages in
>> Golang.
>>
>> [0]
>> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>>
>
> Thank you for reporting. Yeah, it's not used actually for now but
> should be documented. Attached patch.

Committed, thanks!

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-08-14 18:00:57 Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values
Previous Message Peter Geoghegan 2017-08-14 17:41:24 Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values