| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] [meson] add a default option prefix=/usr/local/pgsql |
| Date: | 2022-10-01 01:19:03 |
| Message-ID: | 849725.1664587143@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> I see two potential ways of dealing with this reliably on windows: - error out
> if a prefix is not drive-local, that's easy enough to check, something like:
> normalized_prefix.startswith('/') and not normalized_prefix.startswith('//')
> as the installation on windows is relocatable, that's not too bad a
> restriction - if on windows call a small python helper to compute the path of
> tmp_install + prefix, using the code that meson uses for the purpose
I'd be inclined to keep it simple for now. This seems like something
that could be improved later in a pretty localized way, and it's not
like there's not tons of other things that need work.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-10-01 01:29:26 | Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication |
| Previous Message | Andres Freund | 2022-10-01 01:09:40 | Re: [PATCH v1] [meson] add a default option prefix=/usr/local/pgsql |